Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: deselecting a checkpoint breaks the dashboard in certain scenarios #748

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

vdua
Copy link
Contributor

@vdua vdua commented Jan 14, 2025

fixes #747

Try the same steps with this URL (replace incognito with the correct domain key)

https://deselect-checkpoint--helix-website--vdua.aem.live/tools/oversight/explorer.html?domain=business.adobe.com&filter=&view=month&=performance&checkpoint=click&click.source=button.con-button&domainkey=incognito&conversion.checkpoint=click

Description

We remove the source/target filters from the state if the checkpoint is not present in the filter.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@@ -36,7 +36,7 @@ const API_ENDPOINT = BUNDLER_ENDPOINT;
const elems = {};

const dataChunks = new DataChunks();

window.dataChunks = dataChunks;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove that

@adobe adobe deleted a comment from aem-code-sync bot Jan 14, 2025
@langswei langswei self-requested a review January 15, 2025 00:20
Copy link
Collaborator

@langswei langswei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and tested successfully - thanks!

@langswei langswei merged commit 825f08c into adobe:main Jan 15, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Bug) Deselecting a checkpoint breaks the explorer dashboard
2 participants