Dropzone S2 migration #3429
Open
Dropzone S2 migration #3429
+46,332
−34,887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b2b714d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Expanding the existing themes system to support the new S2 mappings. --- Co-authored-by: castastrophe <[email protected]> Co-authored-by: Patrick Fulton <[email protected]> Co-authored-by: Cory Dransfeldt <[email protected]> Co-authored-by: Aziz Ramos <[email protected]> Co-authored-by: Josh Winn <[email protected]> Co-authored-by: Rise Erpelding <[email protected]> Co-authored-by: Marissa Huysentruyt <[email protected]> Co-authored-by: Rajdeep Chandra <[email protected]> Co-authored-by: TarunAdobe <[email protected]> Co-authored-by: Dragan Eror<[email protected]>
* feat: s2 foundations non-gray-800 colors update * add changeset
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
--- Co-authored-by: TarunAdobe <[email protected]>
--- Co-authored-by: TarunAdobe <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* docs(contextualhelp): remove MDX file - adds some additional documentation regarding stories/variants - migrates documentation in MDX to stories.js instead * docs(fieldgroup): remove MDX file - creates additional templates to showcase variants in a single story on the docs page - additional documentation to give context to stories - corrects sentence-casing in story names - removes duplicate control for label text - migrates documentation in MDX to stories.js instead * chore(fieldgroup,contextualhelp): cleans up test files - fieldgroup: we don't really need to change the label text or help text between test cases, so some of the test-specific changes were removed - contextualhelp: add help icon test case * docs(datepicker): remove MDX file - adds missing date picker docs - migrates documentation in MDX to stories.js instead - creates OpenClosedTemplate to display both states in a single story on the docs page - adds Range variant to the sidebar since that control isn't in the table
* docs(accordion): remove MDX file - adds accordion sizing story - migrates documentation in MDX to stories.js instead * docs(actionbar): remove MDX file - adds actionbar flexible and sticky variants to default/emphasized stories - migrates documentation in MDX to stories.js instead - updates references to mods tables * docs(asset): remove MDX file
…e mdx files (#3409) * docs(colorarea): remove MDX file - adds links to other color components - migrates documentation from MDX to stories file * docs(colorhandle): remove MDX file - adds links to other color components - migrates documentation from MDX to stories file * docs(colorloupe): remove MDX file - migrates documentation from MDX to stories file * docs(colorslider): remove MDX file - migrates documentation from MDX to stories file * docs(colorwheel): remove MDX file - adds missing documentation particularly around the WithColorArea story - migrates documentation from MDX to stories file * docs(colorarea): clarify docs on color area handle * docs(colorslider): add punctuation and reorganize docs
* docs(assetcard): remove MDX file - adds some missing documentation regarding stories, classes and custom properties - corrects sentence-casing of story names * docs(avatar): remove MDX file - adds some missing documentation regarding stories - reorganizes some information to sit with appropriate story/variant - migrates documentation from MDX file to the stories file instead * chore(avatar): fix disabled test arguments * docs(badge): remove MDX file - adds notice badge variants to semantic story - adds sizing story to docs page - migrates documentation in MDX to stories.js instead * docs(badge): pr fixes - remove empty doc block line - remove html wrapper in favor of content array - add notice badge to test coverage
* chore(card): remove default args from test cases * docs(card): remove MDX file - adds some missing documentation regarding stories - reorganizes some information to sit with appropriate story/variant - migrates documentation from MDX file to the stories file instead * docs(coachmark): remove MDX file - adds some missing documentation regarding stories - reorganizes some information to sit with appropriate story/variant - migrates documentation from MDX file to the stories file instead * chore(coachmark): adds extra chromatic coverage * docs(calendar): remove MDX file - migrates documentation from MDX file to the stories file instead * docs(calendar): clarifies days of the week control name * docs(card): clarify quiet control requirements * chore(coachmark): remove html wrapper in favor of content array * chore(card): fix isQuiet controls and usage in template * docs(asset,card): isCardAssetOverride renamed to isImageFill
Includes new color values for Spectrum 2
BREAKING CHANGE: migrates `Action Group` to Spectrum 2, Removes some mod properties
BREAKING CHANGE: migrates Button Group to Spectrum 2 Also: * docs(buttongroup): expand chromatic coverage * refactor(buttongroup): remove extra css classes
BREAKING CHANGE: uses Spectrum 2 tokens
aramos-adobe
force-pushed
the
aramos-adobe/css781-illustrated-message-s2-tokens
branch
from
b244774 to
230c342
Compare
aramos-adobe
force-pushed
the
aramos-adobe/css782-dropzone-s2-migration
branch
from
70c8b73 to
b2b714d
Compare
aramos-adobe
force-pushed
the
aramos-adobe/css781-illustrated-message-s2-tokens
branch
2 times, most recently
from
5a2a335 to
27ac354
Compare
aramos-adobe
force-pushed
the
aramos-adobe/css781-illustrated-message-s2-tokens
branch
2 times, most recently
from
e7f55d8 to
654db3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropzone S2 Migration
Since dropzone shares a lot of illustrated message's new content tokens (typography and spacing), tons of unused
--modswere removed.New mods
--mod-drop-zone-content-heightRemoved mods
--mod-drop-zone-body-color--mod-drop-zone-body-font-family--mod-drop-zone-body-font-style--mod-drop-zone-body-font-weight--mod-drop-zone-body-line-height--mod-drop-zone-content-color--mod-drop-zone-content-edge-to-text--mod-drop-zone-content-font-size--mod-drop-zone-heading-color--mod-drop-zone-heading-font-family--mod-drop-zone-heading-font-size--mod-drop-zone-heading-font-style--mod-drop-zone-heading-font-weight--mod-drop-zone-heading-line-height--mod-drop-zone-heading-to-body--mod-drop-zone-illustration-to-heading--mod-drop-zone-illustration-to-titleHow and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
- [x] Filled reflects hover state
- [x] Filled & Dragged state reflects
replaceRegression testing
Validate:
Screenshots
To-do list