Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experience Event - Proposition Interactions field group #1807

Merged
merged 11 commits into from
Feb 6, 2024

Conversation

kenadobe
Copy link
Contributor

@kenadobe kenadobe commented Jan 25, 2024

#1806
Internal JIRA: https://jira.corp.adobe.com/browse/CJM-59668

Advice needed:
I see other existing attributes all have the meta:titleId and meta:descriptionId fields and they all have some ID on it. Are these 2 attributes automatically generated?

@mjasrotia can you help review it?

Thanks,
Ken

removed the meta:titleId and meta:descriptionId attribute. Will check with the XDM team on how to generate those during PR review.
example json with the new attributes.
xdm:selectionId
xdm:selectionType
xdm:trackingToken
@kenadobe kenadobe marked this pull request as draft January 25, 2024 21:02
@kenadobe kenadobe marked this pull request as ready for review January 30, 2024 18:27
@anandphatak anandphatak self-assigned this Feb 1, 2024
update xdm:selectionId to xdm:selectionID per the contribution guide.
update the xdm:selectionId to xdm:selectionID per contributing guideline.
@kenadobe kenadobe requested a review from anandphatak February 1, 2024 20:07
@anandphatak anandphatak merged commit c494500 into adobe:master Feb 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants