Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply cloud.cfg etc/hosts fix for scaleway #3449

Merged
merged 1 commit into from
Mar 6, 2024
Merged

apply cloud.cfg etc/hosts fix for scaleway #3449

merged 1 commit into from
Mar 6, 2024

Conversation

gdams
Copy link
Member

@gdams gdams commented Mar 6, 2024 •
edited
Loading

Checklist
  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

@gdams gdams requested a review from steelhead31 March 6, 2024 12:06
steelhead31
steelhead31 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sxa
sxa approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel there should be a better way to perform the detection of the problematic environments other than a straight provider check, but 🤷🏻 approving anyway.

@gdams gdams merged commit c6dd3c8 into adoptium:master Mar 6, 2024
9 of 12 checks passed
@gdams gdams deleted the riscv branch March 6, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steelhead31 steelhead31 steelhead31 approved these changes

@sxa sxa sxa approved these changes

Assignees
No one assigned
Labels
ansible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gdams @sxa @steelhead31