-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WinPB: Update Wix Installation To Install SDK #3624
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I've just been chatting to the .NET team, there are dotnet-install scripts you can use. For example: # Windows PowerShell
Invoke-WebRequest -Uri https://dot.net/v1/dotnet-install.ps1 -OutFile "$env:temp/dotnet-install.ps1"; powershell -executionpolicy bypass "$env:temp/dotnet-install.ps1"
# PowerShell Core
Invoke-WebRequest -Uri https://dot.net/v1/dotnet-install.ps1 -OutFile "$env:temp/dotnet-install.ps1"; pwsh "$env:temp/dotnet-install.ps1" This would prevent us having to update the checksum etc |
I tried those, but they install the .net SDK in a user specific folder, which then isn't available to the jenkins user.. as we run the playbooks as an administrator user, but these tools are needed for the jenkins user. |
Can you not run them as the jenkins user? |
Let me give them a quick test. I had issues with the become user elements on our playbook checker ( its on an old version of ansible which has issues... that's a separate issue Im already looking into ) |
I've tried running both as jenkins, as it doesn't get added to the path, it ends up in a <>/.dotnet folder, I think the current solution is more reliable, so I'll leave it like this, as it does work with GHA, and when running the playbooks to build normal machines. |
* WinPB: Update Wix Installation To Install SDK and use correct windows become method. * Linter Fix. * Linter Fix: FQ Run As Method * WindowsPB: Remove redundant output var * WinPB: Update VS2022 CE Download Checksum
Update the Wix5 installation task, as the .NET SDK is not installed by default, and the wix installation requires it.
This also addresses a bug, where the playbook incorrectly uses sudo as a become method, which should be runas in Windows.
Fixes #3617
Checklist