Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade VS2022 Redist devkit to version vs2022_redist_14.40.33807_10.0.26100.1742 #3848

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Dec 18, 2024

As part of moving to the latest VS2022 Redist UCRT DLLs: adoptium/temurin-build#4086
Update Windows image to download: vs2022_redist_14.40.33807_10.0.26100.1742.zip

Checklist

@andrew-m-leonard andrew-m-leonard marked this pull request as draft December 18, 2024 15:43
@andrew-m-leonard andrew-m-leonard self-assigned this Dec 18, 2024
@andrew-m-leonard andrew-m-leonard requested a review from sxa December 18, 2024 15:48
@andrew-m-leonard andrew-m-leonard marked this pull request as ready for review December 18, 2024 15:48
@andrew-m-leonard andrew-m-leonard marked this pull request as draft December 18, 2024 15:48
@andrew-m-leonard andrew-m-leonard marked this pull request as ready for review December 19, 2024 09:19
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this and get it regenerated on the machines today before the next set of EA kick off

@sxa sxa merged commit 1d8d7ec into adoptium:master Dec 19, 2024
9 checks passed
sxa pushed a commit to sxa/infrastructure that referenced this pull request Dec 19, 2024
@sxa
Copy link
Member

sxa commented Dec 19, 2024

Memo to self - backing up the original image with docker tag win2022_notrhel_image win2022_notrhel_image_redist0 before rebuilding.

@sxa
Copy link
Member

sxa commented Dec 19, 2024

I'll merge this and get it regenerated on the machines today before the next set of EA kick off

Testing at https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk21u/job/windbld/1391/console - seems to have started the build without issues so I'm happy if that job goes green overall 👍🏻
I'll get all of the other machines updated now.

@sxa
Copy link
Member

sxa commented Dec 19, 2024

All machines now updated, and the test job referenced in the previous comment has completed ok.
@andrew-m-leonard feel free to check that the artifacts on that build look ok to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants