Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update FAQ.md to include smoke test reproduction #3860

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sxa
Copy link
Member

@sxa sxa commented Jan 15, 2025

Extra information that could be useful for replication which was identified as part of adoptium/temurin-build#4099

Checklist
  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the sentence structure can be inverted here so there's less () style of cavaeting.

FAQ.md Outdated Show resolved Hide resolved
@sxa sxa requested a review from karianna January 15, 2025 21:45
@sxa sxa changed the title doc: updae FAQ.md to include smoke test reproduction doc: update FAQ.md to include smoke test reproduction Jan 16, 2025
@sxa
Copy link
Member Author

sxa commented Jan 16, 2025

Note: Force push above is to fix the typo in the commit message. There have been no additional changes made since Martijn gave his approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants