Fix various SBOM creation problems #4077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andrew-m-leonard
commented
Dec 4, 2024
•
andrew-m-leonard
commented
- Fix benign build ERROR with createSBOM jar SHA list
- Bom.metadata not being created correctly for addComponentProp, luckily it is the first method called, so didn't cause a problem!
- Rededundent addExternalReference and addComponentExtRef were not removed and unittests were actually failing, but they were no being tested with fail on error! so passed!
- Metadata.tools has been deprecated in CycloneDX 1.0.6 spec and will be removed at some point, replaced by ToolInformation.Component
- Add the 3 new extra CycloneDX 1.0.6 dependency jars to the SBOM classpath
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
github-actions
bot
added
jenkins
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
|
@andrew-m-leonard linter fixes required |
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
andrew-m-leonard
requested review from
sxa,
adamfarley and
Haroon-Khel
and removed request for
adamfarley
sxa
approved these changes
Dec 5, 2024
Haroon-Khel
approved these changes
Dec 5, 2024
Co-authored-by: Stewart X Addison <[email protected]>
|
Ill rebase #4075 with these changes once this pr gets merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.