Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RELEASING.md: Add not on how to remove an incorrect tag #4114

Merged
merged 2 commits into from
Jan 11, 2025
Merged

RELEASING.md: Add not on how to remove an incorrect tag #4114

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0aca97
RELEASING.md: Add not on how to remove an incorrect tag
sxa Jan 10, 2025
0ee4ca5
Add blank line to placate linter
sxa Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions RELEASING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,12 @@ git tag -a "jdk-17.0.12-dryrun-ga" jdk-17.0.12+7^{} -m"YYYY.MM release dry run t
git push --tags origin master
```

Note: If you make a mistake with a tag you have already pushed you can undo it with:
```bash
git tag --delete jdk-1.2.3-wrongname
git git push origin :jdk-1.2.3-wrongname
Copy link
Contributor

@Haroon-Khel Haroon-Khel Jan 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this say
git push origin jdk-1.2.3-rightname?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No - the : specifically means "delete in the origin repository on github whereas the first command just deletes it on your local file system. Both are needed, and it doesn't replace the need to run the original commands to recreate and push the correct tag.

You can also use

git push --delete origin jdk-1.2.3-wrongname

instead of the : version - I could change it to that on the basis that it's probably clearer if you think that would be better (I just personally use : because it's shorter!)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Noting that you can also use -d as a shortened version of --delete but my gut feel is that in this document the longer one is clearer)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you meant to repeat git in git git push ....
Also this adds a "note", not a "not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this has already been merged but I'll get a follow on to remove the duplicate git. Thanks.

```

**For the new release versions in the OpenJDK HEAD repository adoptium/jdk:**

```bash
Expand Down
Loading