Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added exception handling for permissions tag in jats #144

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

mugdhapolimera
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.41%. Comparing base (b9aea84) to head (0601cd1).

Files with missing lines Patch % Lines
adsingestp/parsers/jats.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   91.39%   91.41%   +0.02%     
==========================================
  Files          25       25              
  Lines        2881     2889       +8     
==========================================
+ Hits         2633     2641       +8     
  Misses        248      248              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@seasidesparrow seasidesparrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hoping its rare and won't break [m]any existing tests, but I'd like to see an adjustment to jats author handling that strips out markup like \n and \t.

Copy link
Member

@seasidesparrow seasidesparrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, feel free to merge.

@mugdhapolimera mugdhapolimera merged commit dee4e69 into adsabs:main Nov 8, 2024
4 checks passed
@mugdhapolimera mugdhapolimera deleted the jatspermissions branch November 8, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants