Jats email problem iop.20250117 #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: adsingestp/parsers/jats.py new file: tests/stubdata/input/jats_iop_list_embedded_email.xml new file: tests/stubdata/output/jats_iop_list_embedded_email.json modified: tests/test_jats.py
modified: adsingestp/parsers/base.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
==========================================
- Coverage 91.42% 91.36% -0.06%
==========================================
Files 25 25
Lines 2974 2989 +15
==========================================
+ Hits 2719 2731 +12
- Misses 255 258 +3 ☔ View full report in Codecov by Sentry. |
modified: adsingestp/parsers/base.py modified: adsingestp/parsers/jats.py modified: tests/stubdata/input/jats_iop_list_embedded_email.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses an issue where the _fix_email function was receiving emails in list format and trying to parse them as strings, generating an exception.
This also includes a fix to suppress the
MarkupResemblesLocatorWarningmessage from bs4