Fix: adds datacite tests for Zenodo records, moves _detag function fr… #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om JATSParser to BaseBeautifulSoupParser and renames tagsets from JATS_ to HTML_ modified: adsingestp/parsers/base.py modified: adsingestp/parsers/datacite.py modified: adsingestp/parsers/jats.py new file: tests/stubdata/input/zenodo_test.xml new file: tests/stubdata/input/zenodo_test2.xml new file: tests/stubdata/input/zenodo_test3.xml new file: tests/stubdata/input/zenodo_test4.xml modified: tests/stubdata/output/datacite_schema3.1_example-full.json modified: tests/stubdata/output/datacite_schema4.1_example-full.json modified: tests/stubdata/output/datacite_schema4.1_example-software.json modified: tests/stubdata/output/datacite_schema4_example-habanero-pdsdataset.json new file: tests/stubdata/output/zenodo_test.json new file: tests/stubdata/output/zenodo_test2.json new file: tests/stubdata/output/zenodo_test3.json new file: tests/stubdata/output/zenodo_test4.json modified: tests/test_datacite.py
modified: adsingestp/parsers/datacite.py modified: adsingestp/parsers/jats.py modified: tests/stubdata/input/zenodo_test4.xml
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
+ Coverage 88.54% 89.79% +1.25%
==========================================
Files 24 25 +1
Lines 2496 2616 +120
==========================================
+ Hits 2210 2349 +139
+ Misses 286 267 -19
☔ View full report in Codecov by Sentry. |
|
Also adds OA/license capture to to Datacite parser |
ehenneken
reviewed
Nov 7, 2023
| @@ -471,6 +471,35 @@ class BaseBeautifulSoupParser(IngestBase): | |||
| out of the input XML stream. | |||
| """ | |||
|
|
|||
| fix_ampersand = re.compile(r"(&)(.*?)(;)") | |||
|
|
|||
There was a problem hiding this comment.
I don't know if you have ever encountered this in this context: I have seen cases where ampersands got encoded as __amp__amp;
There was a problem hiding this comment.
Do you remember which publisher(s) specifically? I'm looking for an example to make a unit test with.
There was a problem hiding this comment.
This file has an example: /proj/ads/references/sources/MNRAS/0423/iss4.wiley2.xml
modified: adsingestp/parsers/base.py new file: tests/test_base.py
modified: tests/test_base.py
ehenneken
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…om JATSParser to BaseBeautifulSoupParser and renames tagsets from JATS_ to HTML_