Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dublincore parser to replace arxiv parser #84

Merged
merged 4 commits into from
Jan 5, 2024

Conversation

mugdhapolimera
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1ebe706) 89.80% compared to head (fc88789) 89.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   89.80%   89.78%   -0.02%     
==========================================
  Files          25       25              
  Lines        2619     2615       -4     
==========================================
- Hits         2352     2348       -4     
  Misses        267      267              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mugdhapolimera mugdhapolimera linked an issue Jan 4, 2024 that may be closed by this pull request
@seasidesparrow
Copy link
Member

Minor change to dubcore: the PoS records have a <dc:publisher> tag, in this case "Sissa Medialab". I'd like to capture that because there's space for it in base.py (in output["publication"]["publisher"])

I think if you add a few lines to look for dc publisher and then populate self.base_metadata["publisher"], that should be sufficient.

Copy link
Member

@seasidesparrow seasidesparrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please capture the <dc:publisher> tag contents where available into self.base_metadata["publisher"]

Copy link
Member

@seasidesparrow seasidesparrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Merge & release at your convenience.

@mugdhapolimera mugdhapolimera merged commit 0938a1c into adsabs:main Jan 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generalize the ArXiv Parser to cover all dublin core objects
3 participants