-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dublincore parser to replace arxiv parser #84
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
- Coverage 89.80% 89.78% -0.02%
==========================================
Files 25 25
Lines 2619 2615 -4
==========================================
- Hits 2352 2348 -4
Misses 267 267 ☔ View full report in Codecov by Sentry. |
Minor change to dubcore: the PoS records have a I think if you add a few lines to look for dc publisher and then populate self.base_metadata["publisher"], that should be sufficient. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please capture the <dc:publisher>
tag contents where available into self.base_metadata["publisher"]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Merge & release at your convenience.
No description provided.