Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copernicus electronic issn captured correctly #86

Merged
merged 4 commits into from
Feb 14, 2024
Merged

fix: copernicus electronic issn captured correctly #86

merged 4 commits into from
Feb 14, 2024

Conversation

seasidesparrow
Copy link
Member

modified:   adsingestp/parsers/copernicus.py
modified:   tests/stubdata/output/copernicus_ESSD_essd-15-3075-2023.json
modified:   tests/stubdata/output/copernicus_GeChr_gchron-5-323-2023.json
modified:   tests/stubdata/output/copernicus_ISPAn_isprs-annals-X-M-1-2023-237-2023.json
modified:   tests/stubdata/output/copernicus_ISPAr_isprs-archives-XLVIII-M-2-2023-721-2023.json
modified:   tests/stubdata/output/copernicus_wes-8-1625-2023.json
modified:   tests/test_copernicus.py
modified:   tests/stubdata/output/Copernicus_ESSD_essd-15-3075-2023.json
modified:   tests/stubdata/output/Copernicus_GeChr_gchron-5-323-2023.json
modified:   tests/stubdata/output/Copernicus_ISPAn_isprs-annals-X-M-1-2023-237-2023.json
modified:   tests/stubdata/output/Copernicus_ISPAr_isprs-archives-XLVIII-M-2-2023-721-2023.json

 	modified:   adsingestp/parsers/copernicus.py
 	modified:   tests/stubdata/output/copernicus_ESSD_essd-15-3075-2023.json
 	modified:   tests/stubdata/output/copernicus_GeChr_gchron-5-323-2023.json
 	modified:   tests/stubdata/output/copernicus_ISPAn_isprs-annals-X-M-1-2023-237-2023.json
 	modified:   tests/stubdata/output/copernicus_ISPAr_isprs-archives-XLVIII-M-2-2023-721-2023.json
 	modified:   tests/stubdata/output/copernicus_wes-8-1625-2023.json
 	modified:   tests/test_copernicus.py
 	modified:   tests/stubdata/output/Copernicus_ESSD_essd-15-3075-2023.json
 	modified:   tests/stubdata/output/Copernicus_GeChr_gchron-5-323-2023.json
 	modified:   tests/stubdata/output/Copernicus_ISPAn_isprs-annals-X-M-1-2023-237-2023.json
 	modified:   tests/stubdata/output/Copernicus_ISPAr_isprs-archives-XLVIII-M-2-2023-721-2023.json
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0938a1c) 89.78% compared to head (74b2ef0) 89.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   89.78%   89.78%           
=======================================
  Files          25       25           
  Lines        2615     2615           
=======================================
  Hits         2348     2348           
  Misses        267      267           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

 	modified:   pyproject.toml
 	modified:   tests/stubdata/output/Copernicus_ESSD_essd-15-3075-2023.json
 	modified:   tests/stubdata/output/Copernicus_GeChr_gchron-5-323-2023.json
 	modified:   tests/stubdata/output/Copernicus_ISPAn_isprs-annals-X-M-1-2023-237-2023.json
 	modified:   tests/stubdata/output/Copernicus_ISPAr_isprs-archives-XLVIII-M-2-2023-721-2023.json
 	modified:   pyproject.toml
 	modified:   tests/stubdata/output/Copernicus_ESSD_essd-15-3075-2023.json
 	modified:   tests/stubdata/output/Copernicus_GeChr_gchron-5-323-2023.json
 	modified:   tests/stubdata/output/Copernicus_ISPAn_isprs-annals-X-M-1-2023-237-2023.json
 	modified:   tests/stubdata/output/Copernicus_ISPAr_isprs-archives-XLVIII-M-2-2023-721-2023.json
@@ -23,6 +23,7 @@ def setUp(self):
stubdata_dir = os.path.join(os.path.dirname(__file__), "stubdata/")
self.inputdir = os.path.join(stubdata_dir, "input")
self.outputdir = os.path.join(stubdata_dir, "output")
self.maxDiff = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this only for testing? if so, can delete

@mugdhapolimera
Copy link
Contributor

Everything looks good! just one minor suggestion.

 	modified:   tests/test_copernicus.py
 	modified:   tests/stubdata/output/Copernicus_ESSD_essd-15-3075-2023.json
 	modified:   tests/stubdata/output/Copernicus_GeChr_gchron-5-323-2023.json
 	modified:   tests/stubdata/output/Copernicus_ISPAn_isprs-annals-X-M-1-2023-237-2023.json
 	modified:   tests/stubdata/output/Copernicus_ISPAr_isprs-archives-XLVIII-M-2-2023-721-2023.json
@seasidesparrow seasidesparrow merged commit ad90d2f into adsabs:main Feb 14, 2024
4 checks passed
@seasidesparrow seasidesparrow deleted the eissn_copernicus.20240213 branch February 14, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants