Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add download to word cloud #586

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

shinyichen
Copy link
Member

Screenshot 2025-01-16 at 11 08 09 AM

@shinyichen shinyichen requested a review from thostetler January 16, 2025 19:10
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.2%. Comparing base (db2e63f) to head (aea0466).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #586     +/-   ##
========================================
- Coverage    66.2%   66.2%   -0.0%     
========================================
  Files         197     197             
  Lines       22199   22199             
  Branches      588     588             
========================================
- Hits        14682   14680      -2     
- Misses       7510    7512      +2     
  Partials        7       7             

see 1 file with indirect coverage changes

Copy link
Member

@thostetler thostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shinyichen shinyichen merged commit 0eac83a into adsabs:master Jan 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants