Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect practice entries #38

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

tayler6000
Copy link

I found a few practice entries that had either incorrect definitions, were duplicates, or had incorrect formatting.

I wrote a quick Python script to validate the tests. If you'd like, I can send another PR so you can add a GitHub action that automatically validates all the practice files.

TJ Porter added 7 commits January 17, 2025 17:36
ch8
Deleted incorect deal hints from practice and test
Deleted duplicate test entry
Deleted incorrect test entry
Fixed broken test entry
Deleted incorrect test entry
ch8
Fixed incorrect test entry
ch8
Fixed incorrect test entry
@aerickt
Copy link
Owner

aerickt commented Jan 23, 2025

Hey, thanks for the PR! Could you please make sure that the src/practice/ files are also changed? I use mdbook to compile the source files into what you see in book/, so any direct changes in that directory will be erased on the next build.

The Python script would be much appreciated. I don't immediately know if I will go with the GitHub action, but it'd certainly be a great aid by itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants