[fix #219] always qualify unopened imports #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omelkonian
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
LGTM
@jespercockx can you please confirm the removal of catchError was indeed redundant?
Comment on lines
+154
to
+156
| isDataMod <- isJust <$> isDatatypeModule (amodName x) | ||
| return $ QualifiedAs (if isDataMod then Nothing else Just qual) | ||
| _ -> return $ QualifiedAs Nothing |
There was a problem hiding this comment.
Indeed that's much clearer / easier to read.
|
Hm, the |
jespercockx
approved these changes
Nov 8, 2023
|
It doesn't appear to be an artifact and was introduced when the call to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix was easy enough, one branch for qualified imports (without a name) started returned
Nothingafter #202.I changed a few lines that I found very hard to read, but can revert if it isn't to your taste. Also, can the lookup ever fail? I tried removing the
catchErrorline locally and nothing happened on the test suite.