Remove exception details from response

Fixes https://github.com/ahdis/matchbox/security/code-scanning/1 and https://github.com/ahdis/matchbox/security/code-scanning/2
ahdis · Jan 26, 2024 · 8c74f0e · 8c74f0e
1 parent b1a4140
commit 8c74f0e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/...server/src/main/java/ch/ahdis/matchbox/mappinglanguage/StructureMapTransformProvider.java b/...server/src/main/java/ch/ahdis/matchbox/mappinglanguage/StructureMapTransformProvider.java
@@ -156,15 +156,14 @@ public void transform(org.hl7.fhir.r5.model.StructureMap map, HttpServletRequest
     ServletOutputStream output = theServletResponse.getOutputStream();
     try {
       if (output != null) {
-        if (output != null && responseContentType.equals(Constants.CT_FHIR_JSON_NEW))
+        if (responseContentType.equals(Constants.CT_FHIR_JSON_NEW))
           new org.hl7.fhir.r5.elementmodel.JsonParser(matchboxEngine.getContext()).compose(r, output, OutputStyle.PRETTY, null);
         else
           new org.hl7.fhir.r5.elementmodel.XmlParser(matchboxEngine.getContext()).compose(r, output, OutputStyle.PRETTY, null);
       }
     } catch(org.hl7.fhir.exceptions.FHIRException e) {
       log.error("Transform exception", e);
-      output.write("Exception during Transform: ".getBytes());
-      output.write(e.getMessage().getBytes());
+      output.write("Exception during Transform".getBytes());
     }
     theServletResponse.getOutputStream().close();
   }

diff --git a/...r/src/main/java/ch/ahdis/matchbox/questionnaire/QuestionnaireResponseExtractProvider.java b/...r/src/main/java/ch/ahdis/matchbox/questionnaire/QuestionnaireResponseExtractProvider.java
@@ -102,15 +102,14 @@ public void extract(org.hl7.fhir.r5.elementmodel.Element src, HttpServletRequest
     ServletOutputStream output = theServletResponse.getOutputStream();
     try {
       if (output != null) {
-        if (output != null && responseContentType.equals(Constants.CT_FHIR_JSON_NEW))
+        if (responseContentType.equals(Constants.CT_FHIR_JSON_NEW))
           new org.hl7.fhir.r5.elementmodel.JsonParser(matchboxEngine.getContext()).compose(r, output, OutputStyle.PRETTY, null);
         else
           new org.hl7.fhir.r5.elementmodel.XmlParser(matchboxEngine.getContext()).compose(r, output, OutputStyle.PRETTY, null);
       }
     } catch(org.hl7.fhir.exceptions.FHIRException e) {
       log.error("Transform exception", e);
-      output.write("Exception during Transform: ".getBytes());
-      output.write(e.getMessage().getBytes());
+      output.write("Exception during Transform".getBytes());
     }
     theServletResponse.getOutputStream().close();
   }