FML parsing improvement #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oliveregger
commented
Jan 2, 2025
oliveregger
commented
- Performance improvement fml [Updating a map needs 10 seconds in dev mode (onyOneEngine) #323](parsing Updating a map needs 10 seconds in dev mode (onyOneEngine) #323)
- Update org.hl7.fhir.core to 6.5.2 and hapi-fhir to 7.6.1
- Fixing high security issues
qligier
reviewed
Jan 6, 2025
| mapR5.getText().setDiv(new XhtmlNode(NodeType.Element, "div")); | ||
| final String render = StructureMapUtilities.render(mapR5); | ||
| mapR5.getText().getDiv().addTag("pre").addText(render); | ||
| StructureMap mapR5 = MatchboxEngineSupport.mainEngine.parseMapR5(mapText); |
There was a problem hiding this comment.
MatchboxEngine.parseMapR5() doesn't handle the onlyOneEngine mode correctly, and should probably not. I think it's cleaner to handle that in matchbox-server.
There was a problem hiding this comment.
as dicussed: use createR5WorkerContext if we are not in a 5.0.0 context
There was a problem hiding this comment.
updated as discuessed.
qligier
force-pushed
the
oe_fmlupdate
branch
2 times, most recently
from
8ec2170 to
1147509
Compare
qligier
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.