Add a lighten_colors_when_embedding_annotations config (addresses #1259)

ahrm · Dec 19, 2024 · bab683c · bab683c
1 parent fd06141
commit bab683c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/pdf_viewer/config.cpp b/pdf_viewer/config.cpp
@@ -198,6 +198,7 @@ bool USE_LEGACY_KEYBINDS = false;
 bool MULTILINE_MENUS = true;
 bool START_WITH_HELPER_WINDOW = false;
 std::map<std::wstring, std::wstring> ADDITIONAL_COMMANDS;
+bool LIGHTEN_COLORS_WHEN_EMBEDDING_ANNOTATIONS = true;
 
 
 std::map<std::wstring, JsCommandInfo> ADDITIONAL_JAVASCRIPT_COMMANDS;
@@ -987,6 +988,7 @@ ConfigManager::ConfigManager(const Path& default_path, const Path& auto_path, co
     add_bool(L"use_legacy_keybinds", &USE_LEGACY_KEYBINDS);
     add_bool(L"multiline_menus", &MULTILINE_MENUS);
     add_bool(L"start_with_helper_window", &START_WITH_HELPER_WINDOW);
+    add_bool(L"lighten_colors_when_embedding_annotations", &LIGHTEN_COLORS_WHEN_EMBEDDING_ANNOTATIONS);
     add_bool(L"prerender_next_page_presentation", &PRERENDER_NEXT_PAGE);
     add_bool(L"highlight_middle_click", &HIGHLIGHT_MIDDLE_CLICK);
     add_bool(L"auto_rename_downloaded_papers", &AUTO_RENAME_DOWNLOADED_PAPERS);

diff --git a/pdf_viewer/document.cpp b/pdf_viewer/document.cpp
@@ -58,6 +58,7 @@ extern std::wstring SHARED_DATABASE_PATH;
 extern bool DEBUG;
 extern bool EXACT_HIGHLIGHT_SELECT;
 extern std::wstring ANNOTATIONS_DIR_PATH;
+extern bool LIGHTEN_COLORS_WHEN_EMBEDDING_ANNOTATIONS;
 
 int Document::get_mark_index(char symbol) {
     for (size_t i = 0; i < marks.size(); i++) {
@@ -2253,9 +2254,16 @@ void Document::embed_annotations(std::wstring new_file_path) {
         }
         float* color_ = get_highlight_type_color(highlight.type);
         float color[3];
-        // lighten highlight colors before embedding (because we use alpha to make it lighter but
-        // the color doesn't take it into accout). Also see: https://github.com/ahrm/sioyek/issues/667
-        lighten_color(color_, color);
+        if (LIGHTEN_COLORS_WHEN_EMBEDDING_ANNOTATIONS) {
+            // lighten highlight colors before embedding (because we use alpha to make it lighter but
+            // the color doesn't take it into accout). Also see: https://github.com/ahrm/sioyek/issues/667
+            lighten_color(color_, color);
+        }
+        else {
+            color[0] = color_[0];
+            color[1] = color_[1];
+            color[2] = color_[2];
+        }
 
         pdf_set_annot_color(context, highlight_annot, 3, color);
         if (highlight.text_annot.size() > 0) {