Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new three detection events #108

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Added new three detection events #108

merged 1 commit into from
Jan 19, 2024

Conversation

kimhanbeom
Copy link
Contributor

@kimhanbeom kimhanbeom commented Jan 16, 2024

  • Update review-database to 0.23.0.
  • Add WindowsThreat event for windows sysmon events.
  • Add NetworkThreat event for network events.
  • Add ExtraThreat event for misc events.

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (583763e) 47.27% compared to head (3c5de3d) 47.08%.

Files Patch % Lines
src/graphql/event/network.rs 0.00% 25 Missing ⚠️
src/graphql/event.rs 31.81% 15 Missing ⚠️
src/graphql/event/log.rs 0.00% 5 Missing ⚠️
src/graphql/event/sysmon.rs 0.00% 5 Missing ⚠️
src/graphql/category.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   47.27%   47.08%   -0.20%     
==========================================
  Files          62       65       +3     
  Lines       10377    10432      +55     
==========================================
+ Hits         4906     4912       +6     
- Misses       5471     5520      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syncpark
Copy link
Contributor

pending petabi/review-database#176

@syncpark
Copy link
Contributor

@kimhanbeom
Please change Cargo.toml to use review-database 0.23.0

- Update review-database to 0.23.0.
- Add WindowsThreat event for windows sysmon events.
- Add NetworkThreat event for network events.
- Add ExtraThreat event for misc events.
@kimhanbeom kimhanbeom force-pushed the david/add-new-threat branch from 135e652 to 3c5de3d Compare January 19, 2024 04:32
@kimhanbeom kimhanbeom changed the title [WIP] Added new three detection events Added new three detection events Jan 19, 2024
@kimhanbeom kimhanbeom requested a review from syncpark January 19, 2024 04:35
@syncpark syncpark merged commit d7e39e3 into main Jan 19, 2024
8 checks passed
@syncpark syncpark deleted the david/add-new-threat branch January 19, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants