Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether new filter name exists in the database to avoid accidental overwrite #126

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

minshao
Copy link
Contributor

@minshao minshao commented Feb 15, 2024

Resolves #125

@minshao minshao force-pushed the fix-replace-filter branch 3 times, most recently from 348a120 to 5aac29c Compare February 15, 2024 01:27
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 50.75%. Comparing base (cd759e1) to head (e851430).

Files Patch % Lines
src/graphql/filter.rs 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
- Coverage   50.75%   50.75%   -0.01%     
==========================================
  Files          65       65              
  Lines       10926    10928       +2     
==========================================
+ Hits         5546     5547       +1     
- Misses       5380     5381       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msk
Copy link
Contributor

msk commented Feb 15, 2024

@minshao minshao changed the base branch from main to compat-review-database-0.25 February 15, 2024 23:48
@minshao minshao changed the base branch from compat-review-database-0.25 to main February 15, 2024 23:53
@sehkone
Copy link
Contributor

sehkone commented Feb 25, 2024

@minshao , could you resolve the conflicts?

@msk
Copy link
Contributor

msk commented Feb 26, 2024

could you resolve the conflicts?

Resolved the conflict. Please use "Squash and merge" to maintain linear history in main.

@sehkone sehkone merged commit 8f12a1f into aicers:main Feb 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected Behavior in replace_filter Function: Overwrites Existing Filter Without Error
4 participants