Add signInWithNewPassword GraphQL API #291

henry0715-dev · 2024-08-29T05:38:14Z

Close #14

Changed signIn GraphQL API logic.

Returns Err if last_signin_time of account is None.

codecov · 2024-08-29T05:46:28Z

Codecov Report

Attention: Patch coverage is 97.85714% with 6 lines in your changes missing coverage. Please review.

Project coverage is 69.94%. Comparing base (808a3c9) to head (f59e8ca).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/graphql/account.rs	97.85%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
+ Coverage   69.42%   69.94%   +0.52%     
==========================================
  Files          67       67              
  Lines       14037    14274     +237     
==========================================
+ Hits         9745     9984     +239     
+ Misses       4292     4290       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sehkone · 2024-08-29T06:03:53Z

CHANGELOG.md

@@ -68,6 +68,9 @@ Versioning](https://semver.org/spec/v2.0.0.html).
 - Added a `language` field to the `Account`. Consequently, the `account` and
  `accountList` API responses now include this field. The `insertAccount` and
  `updateAccount` GraphQL API endpoints are also updated to support the field.
+- Added `common_sign-in_logic` to handle `sign-in` GraphQL API logic.


This is not necessary because the method is not for users.

I'll delete it.

src/graphql/account.rs

sehkone · 2024-09-02T00:26:43Z

CHANGELOG.md

@@ -68,6 +68,7 @@ Versioning](https://semver.org/spec/v2.0.0.html).
 - Added a `language` field to the `Account`. Consequently, the `account` and
  `accountList` API responses now include this field. The `insertAccount` and
  `updateAccount` GraphQL API endpoints are also updated to support the field.
+- Added `signInWithNewPassword` GraphQL API for signing in with a new password.


This is a new API, so should be included in the section "Added".

Since the signIn has been changed, it should be documented.

I'll change it.

CHANGELOG.md

sehkone · 2024-09-02T04:34:16Z

When reseting the admin's password, we need to reset the last_signin_time as well.

src/graphql/account.rs

sophie-cluml · 2024-09-03T12:26:56Z

@sehkone I know we are still in pr-review stage for this PR, but I think merging PR would require implement new UX flow and design in the client side. So I would like to suggest in advance, that we might merge this PR after we release the upcoming review-web version.

sehkone · 2024-09-03T12:38:46Z

@sehkone I know we are still in pr-review stage for this PR, but I think merging PR would require implement new UX flow and design in the client side. So I would like to suggest in advance, that we might merge this PR after we release the upcoming review-web version.

Yes. I won't merge this until what is required is done.

src/graphql/account.rs

sehkone · 2024-10-30T09:14:51Z

CHANGELOG.md

+### Added
+
+- Added `signInWithNewPassword` GraphQL API for signing in with a new password.
+


@henry0715-dev,

Could you take a look at this? It indicates that unnecessary spaces are included, which suggests you may need to check your editor setup, as VS Code shouldn't have done this if it were set up properly.

I've completed the modification.
Thank you.

sophie-cluml

I'd like to ask you for a rebase please.

src/graphql/account.rs

sophie-cluml · 2024-10-31T05:46:10Z

src/graphql/account.rs

+    ///
+    /// Returns `Err` if the password or the new password are invalid, the access
+    /// doesn't originate from a permitted IP address, or the number of sessions exceeds the
+    /// maximum  limit.


Maybe we only need a single space?

I'll change it.

Could you check this please?

Modification completed.

src/graphql/account.rs

sophie-cluml · 2024-10-31T06:15:48Z

Thank you for your kindness in describing your PR. I would like to suggest a small update to align with our convention. Please consider changing

Changed sign-in GraphQL API logic.

to

Changed signIn GraphQL API logic.

sophie-cluml · 2024-10-31T06:29:29Z

CHANGELOG.md

+### Added
+
+- Added `signInWithNewPassword` GraphQL API for signing in with a new password.
+
 ### Changed



In line with this comment, I noticed that the signIn API logic has been modified. As this logic impacts end users, I think it seems beneficial to explicitly include this change in the changelog to keep our users informed. I’d like to suggest adding a line in the Changed section, perhaps like the following:

The signIn GraphQL API now returns an error if the account was never signed in before. This change is part of enhancing account security by requiring all users to update their passwords upon their first signing in.

sehkone · 2024-10-31T23:50:46Z

I'd like to ask you for a rebase please.

@sophie-cluml,

I don't see any conflicts with the main branch. Why would you think this needs a rebase?

sehkone · 2024-10-31T23:55:30Z

Thank you for your kindness in describing your PR. I would like to suggest a small update to align with our convention. Please consider changing

Changed sign-in GraphQL API logic.

to

Changed signIn GraphQL API logic.

The representation, such as signIn, is not merely conventional. Since it is defined in the schema, we must use it as is.

sehkone · 2024-11-01T00:03:33Z

Thank you for your kindness in describing your PR. I would like to suggest a small update to align with our convention. Please consider changing

Changed sign-in GraphQL API logic.

to

Changed signIn GraphQL API logic.

The representation, such as signIn, is not merely conventional. Since it is defined in the schema, we must use it as is.

One more thing: backticks should be used to quote elements that belong to another context. When we search for a quoted string in the original text, it must appear exactly as quoted. There is no sign-in in our codebase. Across the code and the UI, we only have two representations: sign_in and signIn.

henry0715-dev · 2024-11-01T00:07:26Z

I'd like to ask you for a rebase please.

@sophie-cluml,

I don't see any conflicts with the main branch. Why would you think this needs a rebase?

When I commented, it was conflicting.
Currently, rebase is applied.

henry0715-dev · 2024-11-01T00:12:48Z

Thank you for your kindness in describing your PR. I would like to suggest a small update to align with our convention. Please consider changing

Changed sign-in GraphQL API logic.

to

Changed signIn GraphQL API logic.

The representation, such as signIn, is not merely conventional. Since it is defined in the schema, we must use it as is.

One more thing: backticks should be used to quote elements that belong to another context. When we search for a quoted string in the original text, it must appear exactly as quoted. There is no sign-in in our codebase. Across the code and the UI, we only have two representations: sign_in and signIn.

Commit message modification completed.
Thank you.

sehkone · 2024-11-01T00:33:22Z

Thank you for your kindness in describing your PR. I would like to suggest a small update to align with our convention. Please consider changing

Changed sign-in GraphQL API logic.

to

Changed signIn GraphQL API logic.

The representation, such as signIn, is not merely conventional. Since it is defined in the schema, we must use it as is.

One more thing: backticks should be used to quote elements that belong to another context. When we search for a quoted string in the original text, it must appear exactly as quoted. There is no sign-in in our codebase. Across the code and the UI, we only have two representations: sign_in and signIn.

Commit message modification completed. Thank you.

To clarify further: while backticks are typically used to quote code elements, they can also be applied to any string that might or will appear in a code context. In other words, backticks doesn’t necessarily imply that the enclosed string must be searchable. However, in this CHANGELOG.md, it’s assumed that it should be searchable.

henry0715-dev · 2024-11-03T23:47:33Z

Thank you for your kindness in describing your PR. I would like to suggest a small update to align with our convention. Please consider changing

Changed sign-in GraphQL API logic.

to

Changed signIn GraphQL API logic.

The representation, such as signIn, is not merely conventional. Since it is defined in the schema, we must use it as is.

One more thing: backticks should be used to quote elements that belong to another context. When we search for a quoted string in the original text, it must appear exactly as quoted. There is no sign-in in our codebase. Across the code and the UI, we only have two representations: sign_in and signIn.

Commit message modification completed. Thank you.

To clarify further: while backticks are typically used to quote code elements, they can also be applied to any string that might or will appear in a code context. In other words, backticks doesn’t necessarily imply that the enclosed string must be searchable. However, in this CHANGELOG.md, it’s assumed that it should be searchable.

Thanks for the detailed explanation and guide.
I will be careful with backticks and naming.

sophie-cluml · 2024-11-11T01:53:49Z

CHANGELOG.md

+### Added
+
+- Added `signInWithNewPassword` GraphQL API for signing in with a new password.
+  - The `signIn` GraphQL API now returns an error if the account was never signed


I think we need to break the line before the word "signed". Could you check your IDE settings?

I checked for modification using the cmd + q command in the VSCode IDE.
thank you.

sophie-cluml · 2024-11-13T02:40:04Z

Could you rebase please?

Close #14 Changed `signIn` GraphQL API logic. - Returns `Err` if `last_signin_time` of `account` is `None`.

henry0715-dev · 2024-11-13T03:53:12Z

Could you rebase please?
It's done.

sehkone reviewed Aug 29, 2024

View reviewed changes

src/graphql/account.rs Outdated Show resolved Hide resolved

sehkone reviewed Aug 29, 2024

View reviewed changes

src/graphql/account.rs Outdated Show resolved Hide resolved

henry0715-dev force-pushed the henry/sign-in-with-new-password branch 2 times, most recently from ed652fa to 97ffb90 Compare August 29, 2024 07:08

sehkone reviewed Aug 29, 2024

View reviewed changes

src/graphql/account.rs Outdated Show resolved Hide resolved

sehkone reviewed Aug 29, 2024

View reviewed changes

src/graphql/account.rs Outdated Show resolved Hide resolved

henry0715-dev force-pushed the henry/sign-in-with-new-password branch 3 times, most recently from a5c9935 to 5548e55 Compare August 30, 2024 05:03

henry0715-dev requested a review from sehkone September 1, 2024 23:58

sehkone reviewed Sep 2, 2024

View reviewed changes

src/graphql/account.rs Outdated Show resolved Hide resolved

sehkone reviewed Sep 2, 2024

View reviewed changes

henry0715-dev force-pushed the henry/sign-in-with-new-password branch 2 times, most recently from e72ae31 to 6ebe11b Compare September 2, 2024 01:39

sehkone reviewed Sep 2, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

henry0715-dev force-pushed the henry/sign-in-with-new-password branch 2 times, most recently from e4320fd to acbb168 Compare September 2, 2024 02:41

henry0715-dev force-pushed the henry/sign-in-with-new-password branch 2 times, most recently from fb6cc77 to 17d7dc0 Compare September 3, 2024 06:18

sehkone reviewed Sep 3, 2024

View reviewed changes

src/graphql/account.rs Outdated Show resolved Hide resolved

sehkone reviewed Sep 3, 2024

View reviewed changes

src/graphql/account.rs Outdated Show resolved Hide resolved

sehkone reviewed Sep 3, 2024

View reviewed changes

src/graphql/account.rs Outdated Show resolved Hide resolved

henry0715-dev force-pushed the henry/sign-in-with-new-password branch from 17d7dc0 to 8912b70 Compare September 4, 2024 00:05

sehkone reviewed Sep 4, 2024

View reviewed changes

src/graphql/account.rs Show resolved Hide resolved

henry0715-dev force-pushed the henry/sign-in-with-new-password branch from 8912b70 to a743b94 Compare September 4, 2024 05:01

msk mentioned this pull request Oct 1, 2024

첫 로그인 시 계정 비밀번호 변경을 위한 새로운 GraphQL mutation 구현 #14

Closed

henry0715-dev force-pushed the henry/sign-in-with-new-password branch from a743b94 to f6c36ab Compare October 21, 2024 07:37

sehkone reviewed Oct 30, 2024

View reviewed changes

henry0715-dev force-pushed the henry/sign-in-with-new-password branch from f6c36ab to 29f4dfd Compare October 30, 2024 22:38

henry0715-dev requested a review from sehkone October 30, 2024 22:39

sophie-cluml reviewed Oct 31, 2024

View reviewed changes

henry0715-dev force-pushed the henry/sign-in-with-new-password branch from 29f4dfd to f08c5ef Compare October 31, 2024 23:41

henry0715-dev force-pushed the henry/sign-in-with-new-password branch from f08c5ef to 01e777c Compare November 1, 2024 00:11

henry0715-dev requested a review from sophie-cluml November 3, 2024 23:47

henry0715-dev force-pushed the henry/sign-in-with-new-password branch from 01e777c to 389bd6c Compare November 7, 2024 07:33

sophie-cluml reviewed Nov 11, 2024

View reviewed changes

henry0715-dev force-pushed the henry/sign-in-with-new-password branch from 389bd6c to 16a9872 Compare November 13, 2024 00:26

sophie-cluml approved these changes Nov 13, 2024

View reviewed changes

sehkone mentioned this pull request Nov 13, 2024

Release 0.24.0 #354

Closed

Add signInWithNewPassword GraphQL API

f59e8ca

Close #14 Changed `signIn` GraphQL API logic. - Returns `Err` if `last_signin_time` of `account` is `None`.

henry0715-dev force-pushed the henry/sign-in-with-new-password branch from 16a9872 to f59e8ca Compare November 13, 2024 03:52

sophie-cluml approved these changes Nov 13, 2024

View reviewed changes

sehkone merged commit 2b008be into main Nov 15, 2024
10 checks passed

sehkone deleted the henry/sign-in-with-new-password branch November 15, 2024 02:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add signInWithNewPassword GraphQL API #291

Add signInWithNewPassword GraphQL API #291

henry0715-dev commented Aug 29, 2024 •

edited

Loading

codecov bot commented Aug 29, 2024 •

edited

Loading

sehkone Aug 29, 2024

henry0715-dev Aug 29, 2024

sehkone Sep 2, 2024

sehkone Sep 2, 2024

henry0715-dev Sep 2, 2024

sehkone commented Sep 2, 2024

sophie-cluml commented Sep 3, 2024

sehkone commented Sep 3, 2024

sehkone Oct 30, 2024

henry0715-dev Oct 30, 2024

sophie-cluml left a comment

sophie-cluml Oct 31, 2024

henry0715-dev Oct 31, 2024

sophie-cluml Nov 7, 2024

henry0715-dev Nov 7, 2024

sophie-cluml commented Oct 31, 2024

sophie-cluml Oct 31, 2024 •

edited

Loading

sehkone commented Oct 31, 2024

sehkone commented Oct 31, 2024

sehkone commented Nov 1, 2024

henry0715-dev commented Nov 1, 2024

henry0715-dev commented Nov 1, 2024

sehkone commented Nov 1, 2024 •

edited

Loading

henry0715-dev commented Nov 3, 2024

sophie-cluml Nov 11, 2024

henry0715-dev Nov 13, 2024

sophie-cluml commented Nov 13, 2024

henry0715-dev commented Nov 13, 2024

		### Added

		- Added `signInWithNewPassword` GraphQL API for signing in with a new password.

Add signInWithNewPassword GraphQL API #291

Add signInWithNewPassword GraphQL API #291

Conversation

henry0715-dev commented Aug 29, 2024 • edited Loading

codecov bot commented Aug 29, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sehkone commented Sep 2, 2024

sophie-cluml commented Sep 3, 2024

sehkone commented Sep 3, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sophie-cluml left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sophie-cluml commented Oct 31, 2024

sophie-cluml Oct 31, 2024 • edited Loading

Choose a reason for hiding this comment

sehkone commented Oct 31, 2024

sehkone commented Oct 31, 2024

sehkone commented Nov 1, 2024

henry0715-dev commented Nov 1, 2024

henry0715-dev commented Nov 1, 2024

sehkone commented Nov 1, 2024 • edited Loading

henry0715-dev commented Nov 3, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sophie-cluml commented Nov 13, 2024

henry0715-dev commented Nov 13, 2024

henry0715-dev commented Aug 29, 2024 •

edited

Loading

codecov bot commented Aug 29, 2024 •

edited

Loading

sophie-cluml Oct 31, 2024 •

edited

Loading

sehkone commented Nov 1, 2024 •

edited

Loading