Let async-graphql handle cursor encoding/decoding #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
async-graphql's `query' function automatically handles cursor encoding and decoding. This commit removes the custom cursor encoding/decoding code from the `slicing' module and uses async-graphql's built-in functionality instead.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
==========================================
- Coverage 68.48% 68.36% -0.12%
==========================================
Files 67 67
Lines 13560 13595 +35
==========================================
+ Hits 9286 9294 +8
- Misses 4274 4301 +27 ☔ View full report in Codecov by Sentry. |
sehkone
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
async-graphql's
queryfunction automatically handles cursor encoding and decoding. This commit removes the custom cursor encoding/decoding code from theslicingmodule and uses async-graphql's built-in functionality instead. This change only updates theslicingmodule to keep the PR minimal, and a follow-up change will be needed to address the top-levelencode_cursoranddecode_cursorfunctions in thegraphqlmodule.