Update updateNodeDraft
#349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
==========================================
+ Coverage 68.52% 69.29% +0.76%
==========================================
Files 67 67
Lines 13665 14007 +342
==========================================
+ Hits 9364 9706 +342
Misses 4301 4301 ☔ View full report in Codecov by Sentry. |
sophie-cluml
reviewed
Nov 4, 2024
BLYKIM
force-pushed
the
bly/update_node_draft
branch
2 times, most recently
from
fe599c9 to
37508b3
Compare
sophie-cluml
approved these changes
Nov 6, 2024
sehkone
reviewed
Nov 7, 2024
src/graphql/node/input.rs
Outdated
Comment on lines
147
to
148
| .cloned() | ||
| .and_then(|config| config.and_then(|c| c.try_into().ok())); |
There was a problem hiding this comment.
This is good enough. However, I would suggest using clone as late as possible in the code, as it helps convey why clone is inevitable.
- `updateNodeDraft` GraphQL API to no longer require `config` in `NodeDraftInput::agents`.
BLYKIM
force-pushed
the
bly/update_node_draft
branch
from
37508b3 to
3de06cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updateNodeDraftGraphQL API to no longer requireconfiginNodeDraftInput::agents.Close: #335