Update AgentKind enum variants
#352
Conversation
danbi2990
force-pushed
the
jake/update-agentkind
branch
from
0e44dde to
2c185de
Compare
danbi2990
changed the title
AgentKind enum variantsAgentKind enum variants
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #352 +/- ##
==========================================
- Coverage 69.29% 69.29% -0.01%
==========================================
Files 67 67
Lines 14007 14015 +8
==========================================
+ Hits 9706 9711 +5
- Misses 4301 4304 +3 ☔ View full report in Codecov by Sentry. |
danbi2990
force-pushed
the
jake/update-agentkind
branch
from
2c185de to
7e9ceaf
Compare
danbi2990
changed the title
AgentKind enum variantsAgentKind enum variants
src/graphql/event.rs
Outdated
| @@ -1298,7 +1298,7 @@ mod tests { | |||
| hostname: "collector1", | |||
| agents: [{ | |||
| key: "piglet" | |||
There was a problem hiding this comment.
I think it would be better to change this to the new nickname. This way, we can completely avoid mentioning the previous names.
There was a problem hiding this comment.
All keys have been updated.
For consistency, also updated:
learner => unsupervised
models => semi_supervised
features => sensor
danbi2990
force-pushed
the
jake/update-agentkind
branch
from
7e9ceaf to
49b7010
Compare
src/graphql.rs
Outdated
| @@ -593,22 +593,25 @@ impl AgentManager for MockAgentManager { | |||
| &self, | |||
| _networks: &HostNetworkGroup, | |||
| ) -> Result<Vec<String>, anyhow::Error> { | |||
| Ok(vec!["hog@hostA".to_string()]) | |||
| Ok(vec!["semi_supervised@hostA".to_string()]) | |||
There was a problem hiding this comment.
semi-supervised is a definitely better option.
There was a problem hiding this comment.
Applied suggested adjustment. Thank you.
danbi2990
force-pushed
the
jake/update-agentkind
branch
2 times, most recently
from
837b003 to
614de29
Compare
|
Could you rebase please? |
danbi2990
force-pushed
the
jake/update-agentkind
branch
from
614de29 to
53e0561
Compare
- Update review-database to 0.32.0 - Rename previous enum variants to align with review-database - Add `TimeSeriesGenerator` variant Close: #351
danbi2990
force-pushed
the
jake/update-agentkind
branch
from
53e0561 to
b77141a
Compare
Done rebase. Thank you. |
AgentKindenum variants to align with review-databaseTimeSeriesGeneratorvariantClose: #351