Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom cursor encoding with OpaqueCursor #366

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

msk
Copy link
Contributor

@msk msk commented Dec 5, 2024

This replaces the custom cursor encoding and decoding logic with the OpaqueCursor type provided by async-graphql. This simplifies the code and reduces the risk of errors in cursor handling.

Note that this change breaks backwards compatibility with older versions of the GraphQL API, as the cursor format has changed.

msk added 2 commits December 5, 2024 12:33
This change removes the reliance on a separate type (`IndexedKey`)
implementing `CursorType`.
@msk msk added the refactor Refactoring to improve code quality label Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 70.38%. Comparing base (238fb77) to head (62cf9fe).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/graphql/cluster.rs 0.00% 7 Missing ⚠️
src/graphql/model.rs 0.00% 7 Missing ⚠️
src/graphql/statistics.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
+ Coverage   70.26%   70.38%   +0.11%     
==========================================
  Files          67       67              
  Lines       14400    14376      -24     
==========================================
  Hits        10118    10118              
+ Misses       4282     4258      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sehkone sehkone merged commit 649bac0 into aicers:main Dec 12, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring to improve code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants