Update insertNode
#381
Merged
Update insertNode
#381
+31
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #381 +/- ##
==========================================
+ Coverage 71.32% 71.33% +0.01%
==========================================
Files 67 67
Lines 14661 14667 +6
==========================================
+ Hits 10457 10463 +6
Misses 4204 4204 ☔ View full report in Codecov by Sentry. |
sophie-cluml
approved these changes
Jan 3, 2025
|
@BLYKIM, could you rebase this? |
- `insertNode` GraphQL API no longer requires `config` for the `agents` parameter.
BLYKIM
force-pushed
the
bly/remove_insert_config
branch
from
7a709c0 to
7ab2045
Compare
sehkone
reviewed
Jan 13, 2025
| Some(draft) => Some( | ||
| draft | ||
| .try_into() | ||
| .map_err(|_| Error::new("Failed to convert agent draft"))?, |
There was a problem hiding this comment.
This only informs users that a failure occurred, without specifying which agents the conversion failed on. I think it would be necessary to address that in a separate issue later. Could you create an issue regarding it?
There was a problem hiding this comment.
#387 관련 이슈 생성해두었습니다.
sehkone
approved these changes
Jan 13, 2025
|
@BLYKIM, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
insertNodeGraphQL API no longer requiresconfigfor theagentsparameter.Close: #350