Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete reset_admin_password function #386

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

msk
Copy link
Contributor

@msk msk commented Jan 12, 2025

This PR removes the reset_admin_password function from the graphql::account module, as it has been obsoleted by the resetAdminPassword GraphQL API mutation.

The reset_admin_password function was previously used by the QUIC API, but since the QUIC API has been replaced with the GraphQL API mutation instead, this function is no longer needed.

Note: CI is currently failing due to a Clippy warning, but this will be resolved once #385 is merged.

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.34%. Comparing base (3aebb1b) to head (7dd139d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
+ Coverage   71.32%   71.34%   +0.01%     
==========================================
  Files          67       67              
  Lines       14666    14657       -9     
==========================================
- Hits        10461    10457       -4     
+ Misses       4205     4200       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sehkone sehkone enabled auto-merge (squash) January 13, 2025 06:02
@sehkone sehkone disabled auto-merge January 13, 2025 06:03
@sehkone sehkone merged commit b5e1348 into aicers:main Jan 13, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants