Remove obsolete reset_admin_password function #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #386 +/- ##
==========================================
+ Coverage 71.32% 71.34% +0.01%
==========================================
Files 67 67
Lines 14666 14657 -9
==========================================
- Hits 10461 10457 -4
+ Misses 4205 4200 -5 ☔ View full report in Codecov by Sentry. |
sehkone
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
reset_admin_passwordfunction from thegraphql::accountmodule, as it has been obsoleted by theresetAdminPasswordGraphQL API mutation.The
reset_admin_passwordfunction was previously used by the QUIC API, but since the QUIC API has been replaced with the GraphQL API mutation instead, this function is no longer needed.Note: CI is currently failing due to a Clippy warning, but this will be resolved once #385 is merged.