Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the type of id in ranked_outlier/saved_outlier queries to StringNumber #84

Merged
merged 1 commit into from
Nov 7, 2023
+11 −4
Merged

Change the type of id in ranked_outlier/saved_outlier queries to StringNumber #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ file is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and
this project adheres to [Semantic
Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

### Changed

- Change the type of `id` in `ranked_outlier`/`saved_outlier` queries to `StringNumber`.

## [0.14.5] - 2023-11-02

### Changed
Expand Down Expand Up @@ -320,6 +326,7 @@ across our system.

- An initial version.

[Unreleased]: https://github.com/aicers/review-web/compare/0.14.5...main
[0.14.5]: https://github.com/aicers/review-web/compare/0.14.4...0.14.5
[0.14.4]: https://github.com/aicers/review-web/compare/0.14.3...0.14.4
[0.14.3]: https://github.com/aicers/review-web/compare/0.14.2...0.14.3
Expand Down
4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
[package]
name = "review-web"
version = "0.14.5"
version = "0.15.0-alpha.1"
edition = "2021"

[dependencies]
anyhow = "1"
async-graphql = { version = "6", features = ["chrono"] }
async-graphql = { version = "6", features = ["chrono", "string_number"] }
async-graphql-axum = "6"
async-trait = "0.1"
axum = { version = "0.6", features = ["headers", "macros"] }
Expand Down
4 changes: 2 additions & 2 deletions src/graphql/outlier.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use crate::graphql::{earliest_key, latest_key};
use anyhow::anyhow;
use async_graphql::{
connection::{query, Connection, Edge, EmptyFields},
types::ID,
types::{StringNumber, ID},
ComplexObject, Context, InputObject, Object, ObjectType, OutputType, Result, SimpleObject,
};
use bincode::Options;
Expand Down Expand Up @@ -188,7 +188,7 @@ async fn load_outliers(

#[derive(Debug, SimpleObject)]
pub(super) struct RankedOutlier {
id: i64,
id: StringNumber<i64>,
model_id: i32,
timestamp: i64,
rank: i64,
Expand Down