Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify ranked_outliers distance search condition & Release 0.15.0 #89

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

sehkone
Copy link
Contributor

@sehkone sehkone commented Nov 15, 2023

  • Change the distance search criteria to support a single search.
  • Change the type of id in the Rankedoutlier field from StringNumber to ID.
  • Change the part about RankedOutlierTotalCount to count the total count differently.
  • Bump version to 0.15.0

Closes: #83, #87, #88

)

- Change the distance search criteria to support a single search.
- Change the type of id in the `Rankedoutlier` field from `StringNumber` to `ID`.
- Change the part about `RankedOutlierTotalCount` to count the total count differently.
- Bump version to 0.15.0

Closes: #83, #87, #88
@sehkone
Copy link
Contributor Author

sehkone commented Nov 15, 2023

@MW-Kim , @kimhanbeom , 커밋 메시지에 버전이 0.15.0가 아닌 0.14.6으로 적혀 있었습니다. 커밋 메시지에 약간의 오류가 있을 수는 있으나, 이런 오류는 큰 혼동을 줄 수 있으므로 수정합니다. 기존에 push한 0.15.0 tag는 제가 삭제하였습니다. 이 PR을 merge한 후에 다시 tag 붙여 주세요.

@codecov-commenter
Copy link

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (b2ac87b) 48.37% compared to head (148d73c) 48.35%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/graphql/outlier.rs 0.00% 10 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   48.37%   48.35%   -0.02%     
==========================================
  Files          62       62              
  Lines       10104    10108       +4     
==========================================
  Hits         4888     4888              
- Misses       5216     5220       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kimhanbeom kimhanbeom merged commit e207566 into main Nov 16, 2023
8 checks passed
@kimhanbeom kimhanbeom deleted the correct-commit-msg branch November 16, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Corruption of id in ranked outlier graphql requests.
3 participants