Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify fields in Node #95

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Modify fields in Node #95

merged 1 commit into from
Dec 7, 2023

Conversation

dayeon5470
Copy link
Contributor

Fixes #81

@dayeon5470 dayeon5470 force-pushed the modify_node branch 2 times, most recently from 4689e7b to b439b0c Compare December 4, 2023 02:11
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2023

Codecov Report

Attention: 143 lines in your changes are missing coverage. Please review.

Comparison is base (b47549c) 47.17% compared to head (f8facfa) 47.40%.

Files Patch % Lines
src/graphql/node/crud.rs 45.39% 89 Missing ⚠️
src/graphql/node/input.rs 69.54% 53 Missing ⚠️
src/graphql/node.rs 99.04% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   47.17%   47.40%   +0.22%     
==========================================
  Files          62       62              
  Lines       10138    10286     +148     
==========================================
+ Hits         4783     4876      +93     
- Misses       5355     5410      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/graphql/node.rs Outdated Show resolved Hide resolved
src/graphql/node/crud.rs Outdated Show resolved Hide resolved
src/graphql/node/input.rs Outdated Show resolved Hide resolved
src/graphql/node/crud.rs Outdated Show resolved Hide resolved
src/graphql/node/crud.rs Outdated Show resolved Hide resolved
src/graphql/node/crud.rs Outdated Show resolved Hide resolved
src/graphql/node/crud.rs Outdated Show resolved Hide resolved
src/graphql/node/crud.rs Outdated Show resolved Hide resolved
src/graphql/node/crud.rs Outdated Show resolved Hide resolved
src/graphql/node/crud.rs Outdated Show resolved Hide resolved
src/graphql/node/crud.rs Outdated Show resolved Hide resolved
src/graphql/node/crud.rs Outdated Show resolved Hide resolved
@sehkone sehkone changed the title Modify node menu Modify fields in Node Dec 5, 2023
@sehkone sehkone requested a review from sophie-cluml December 5, 2023 04:47
@dayeon5470 dayeon5470 force-pushed the modify_node branch 2 times, most recently from 1c59965 to bcc68f0 Compare December 5, 2023 07:10
src/graphql/node/crud.rs Show resolved Hide resolved
src/graphql/node.rs Show resolved Hide resolved
src/graphql/node/crud.rs Outdated Show resolved Hide resolved
src/graphql/node/crud.rs Outdated Show resolved Hide resolved
@dayeon5470 dayeon5470 force-pushed the modify_node branch 5 times, most recently from 6369b3d to 2cad532 Compare December 6, 2023 01:12
Copy link
Contributor

@sophie-cluml sophie-cluml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sehkone sehkone merged commit 3f9ab78 into main Dec 7, 2023
8 checks passed
@sehkone sehkone deleted the modify_node branch December 7, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify the Node definition and the associated GraphQL APIs accordingly.
4 participants