Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip React detection in iframes and popups #96

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

pivanov
Copy link
Collaborator

@pivanov pivanov commented Dec 9, 2024

  • Add detection for iframes and popups using window properties
  • Skip React detection when window is not a standard one

Closes #87

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
react-scan ⬜️ Skipped (Inspect) Dec 9, 2024 7:18pm

Copy link

vercel bot commented Dec 9, 2024

@pivanov is attempting to deploy a commit to the Million Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

pkg-pr-new bot commented Dec 9, 2024

Open in Stackblitz

npm i https://pkg.pr.new/aidenybai/react-scan@96

commit: 69024aa

@pivanov pivanov force-pushed the fix/skip-iframe-popup-windows branch from 69024aa to 5b0c0b9 Compare December 9, 2024 19:18
@pivanov pivanov merged commit c421fba into aidenybai:main Dec 9, 2024
2 of 3 checks passed
@pivanov pivanov deleted the fix/skip-iframe-popup-windows branch December 9, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chrome extension maybe trying to load on iframes
1 participant