Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Cartpole Evolutionary Example #46

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

veds12
Copy link

@veds12 veds12 commented Jul 21, 2021

Description:
This is an example for training the Cartpole robot using the new SupervisorEvolutionary class of deepbots

To Do:

  • Add cuda support
  • Find optimal hyperparams for ga_solver
  • Add wandb logging

@veds12 veds12 marked this pull request as draft July 21, 2021 16:02
@veds12 veds12 marked this pull request as ready for review August 21, 2021 02:28
@KelvinYang0320
Copy link
Member

@veds12 Thank you for this great addition to the repository! 😄
I guess that your SupervisorEvolutionary is from the PR you're about to contribute to deepbots package.
Are you planning to finish the last task, Extend to multi-robot, as you mentioned in the PR first?
From these lines, I think this example is still in progress.
If that is the case, I will do the code review later.
Or you would like to contribute this single carpole example first?

@veds12
Copy link
Author

veds12 commented Aug 28, 2021

Hi @KelvinYang0320. Yes, I still need to extend the SupervisorEvolutionary class to support multiple-robots. Two things that can be done are: We merge the current SupervisorEvolutionary PR and I open a separate PR for the last task, i.e. extend to multiple robots, and then working or merging this PR as well. Or we can wait till I update the SupervisorEvolutionary in the existing PR itself and then check the code. I'd prefer the later one for the sake of completeness, in which case, there's no need to check this PR right now.

@KelvinYang0320
Copy link
Member

Hello @veds12,
I'm with you on that.
We can wait till you update the SupervisorEvolutionary for the last task in the existing PR and then check this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants