Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update nushell init script #966

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

update nushell init script #966

wants to merge 2 commits into from

Conversation

Bahex
Copy link

@Bahex Bahex commented Jan 5, 2025

  1. Made __zoxide_z more idiomatic
  2. Updated the hook initialization to avoid breakage on nushell's future 0.102.0 release

To expand on hook initialization:
After nushell/nushell#14704 (comment), starting sub shells would make zoxide's init script throw an error.

With this PR $env.__zoxide_hooked is no longer used. Instead, the list of hooks are checked directly to see if zoxide's hook has already been added.

I checked the new init script on both nushell version 0.89.0 and the latest nushell nightly.
Minimum supported version of nushell doesn't need to change and can be kept at 0.89.0

@ajeetdsouza ajeetdsouza force-pushed the main branch 3 times, most recently from c770a05 to 3fe42e9 Compare January 8, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant