Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fig kwargs provision on MapPlot #924

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Fix fig kwargs provision on MapPlot #924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0218e1
chore: bump ruff
akrherz Jun 24, 2024
64c2494
fix: pop fig on kwargs
akrherz Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ ci:
autoupdate_schedule: quarterly
repos:
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: "v0.4.7"
rev: "v0.4.10"
hooks:
- id: ruff
args: [--fix, --exit-non-zero-on-fix]
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ All notable changes to this library are documented in this file.

### Bug Fixes

- Pop kwargs `fig` on `MapPlot`.
- Use less confusing landing page at WPC for ERO.

## **1.20.0** (31 May 2024)
Expand Down
2 changes: 1 addition & 1 deletion src/pyiem/plot/geoplot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ def __init__(self, sector="iowa", **kwargs):
only option currently.
"""
self.debug = kwargs.get("debug", False)
self.fig = kwargs.get("fig")
self.fig = kwargs.pop("fig", None)
figsize = kwargs.get("figsize", FIGSIZES["43"])
if kwargs.get("twitter", False) is True:
figsize = TWITTER_RESOLUTION_INCH
Expand Down
Loading