Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix location autocomplete dropdown background #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cdreetz
Copy link

@cdreetz cdreetz commented Jan 19, 2025

fix location dropdown bg in dark mode, previously was white on white and undreadable


Important

Fixes dark mode readability issue for location autocomplete dropdown in places-autocomplete.tsx.

  • UI Fix:
    • In places-autocomplete.tsx, change dropdown background from bg-white to bg-background for dark mode compatibility.
    • Update list item hover and selected background from bg-gray-100 to bg-accent and text color to text-foreground.

This description was created by Ellipsis for 7d4dc82. It will automatically update as commits are pushed.

Copy link

vercel bot commented Jan 19, 2025

@cdreetz is attempting to deploy a commit to the basecase Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 7d4dc82 in 9 seconds

More details
  • Looked at 20 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. components/places-autocomplete.tsx:86
  • Draft comment:
    Ensure that bg-background and text-foreground are defined in your theme to avoid any styling issues.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR changes the background color of the dropdown and the hover/selected state colors. These changes are consistent with the intent to fix the dark mode issue.

Workflow ID: wflow_4bGuH7ZeKPtwljND


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant