feat: v7 upgrade #14
Merged
feat: v7 upgrade #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
sdmcraft
reviewed
Dec 10, 2022
| const classNameClipped = className.slice(0, -1); | ||
| const classNames = classNameClipped.split('--'); | ||
| brand.className = classNames.join(' '); | ||
| brand.className = className; |
There was a problem hiding this comment.
@rhudea , this gnav block was copied over from the blog repo and I see that the change you propose here isn't done there for a similar PR for v7 upgrade. So I am not really sue if we require this change for v7 upgrade. If yes, should this also be done for the blog site's PR? Could you please add you inputs?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade from v6 to v7. See adobe/helix-html-pipeline#57 for breaking changes introduced with v7.
Test URLs: