Add SmartCotnent ArticleDataProvider #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } elseif ('created' === $field) { | ||
| $queryBuilder->addOrderBy('article.created', $order); | ||
| } elseif (\in_array($field, ['title', 'authored', 'workflowPublished'])) { | ||
| $this->joinDimensionContent($queryBuilder, 'article'); |
There was a problem hiding this comment.
I would extend the addSortBys to dimensionContentQueryEnhancer.
| @@ -260,4 +287,27 @@ private function createQueryBuilder(array $filters, array $sortBy = [], array $s | |||
|
|
|||
| return $queryBuilder; | |||
| } | |||
|
|
|||
| private function joinDimensionContent(QueryBuilder $queryBuilder, string $alias): void | |||
There was a problem hiding this comment.
we should move dimension based part to the dimensionContentQueryEnhancer service
alexander-schranz
force-pushed
the
feature/content-article-repository
branch
from
77e1b9d to
1394d5f
Compare
alexander-schranz
force-pushed
the
feature/smart-content
branch
from
d6941c7 to
b3546c7
Compare
alexander-schranz
changed the title
alexander-schranz
merged commit 2ad5c17
into
alexander-schranz:feature/content-article-repository
0 of 6 checks passed
alexander-schranz
pushed a commit
that referenced
this pull request
Aug 8, 2024
alexander-schranz
pushed a commit
that referenced
this pull request
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Explain the contents of the PR.
Why?
Which problem does the PR fix? (remove this section if you linked an issue above)
Example Usage
BC Breaks/Deprecations
Describe BC breaks/deprecations here. (remove this section if not needed)
To Do