Fix Nevada-Foxx crash on Linux/Webassembly platform #325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current implementation we assume that
compat_splitpath
will receive files with/
when we are running on Linux platform. This is mostly true except cases when path is originated fromddraw.ini
. Here is example from "Nevada build by Foxx":NOTE: One should run this on case-insensitive file system or rename folders according to configuration. No folder - no bug and no global scripts of course.
So, in this PR we use another compat_splitpath implementation which works on both
/
and\
Here are unit tests for this, it will be good to include them directly into codebase and setup CI check (do you have any ideas how to make it?)