Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --uppercase-hex #75

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WaffleLapkin
Copy link

@WaffleLapkin WaffleLapkin commented Dec 22, 2024

--uppercase-hex makes dominant_colours output uppercase hex (#7DC07B), instead of lowercase (#7dc07b) when printing color codes.

I find uppercase hex to be easier to read, since all digits (including letters) are the same height.

I have some ideas on minor improvements/cleanups to the code, but I'm unsure if you are interested in that. LMK if you do!

@WaffleLapkin
Copy link
Author

Hm. While playing around with dominant_colours I added a few more options, like --sort (sorts the output in "most common to least common" order, IMO should be the default), --amount (not sure if the best name, shows the % of the image that is closest to that colour, besacally the key for --sort), --seed (for the rng in kmeans), options to control resizing (max size, alg), --index-image (outputs an "indexed" image, using dominant colours), and --sort-index (kind of silly, sorts the output of --index-image, helpful to visually see how much of which color is there in the picture).

On one hand I do like being able play with all those options, but on the other hand I see how this kind-of clatters otherwise very simple CLI. What do you think @alexwlchan? Are you interested in any of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant