-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Googles Services Endpoints #7
Draft
ilitteri
wants to merge
54
commits into
main
Choose a base branch
from
feature/google_services_endpoints
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests don't run because of a tokio runtime bug
This way will allow extensibility for other API needs
Add prerrequisites section
This way will allow extensibility for other API needs
Add how to run tests section
Rename section
* Add test coverage workflow * Downgrade codecov version * Add rusty-hook * Remove codecov for the moment because of a bug * Add CircleCI for fmt, clippy and test running * Fix rust version in workflow * Fix rust version in workflow for allthe jobs * Remove .tarpaulin for the moment
- Added helpsheet_id argument - Update next handler & filter - Update dismiss_help handler & filter
Removing Google Service trait for the moment. Now it is a single struct. We'll try do this with traits in the future
Added a new test directive for getting the next class
…eature/google_services_endpoints
ilitteri
requested review from
IAvecilla,
josuebouchard and
TomasSzeSirk
and removed request for
josuebouchard,
IAvecilla and
TomasSzeSirk
September 6, 2022 23:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs relacionados
Este PR depende de #3.
Motivación
El bot de discord necesita: