-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add MaxVolumesPerNode
setting
#242
feat: add MaxVolumesPerNode
setting
#242
Conversation
Signed-off-by: dongjiang1989 <[email protected]>
Signed-off-by: dongjiang1989 <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #242 +/- ##
==========================================
- Coverage 32.31% 32.24% -0.08%
==========================================
Files 41 41
Lines 6411 6426 +15
==========================================
Hits 2072 2072
- Misses 4050 4065 +15
Partials 289 289
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: dongjiang1989 <[email protected]>
Signed-off-by: dongjiang1989 <[email protected]>
@peter-wangxu addressed comments, please review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, but some nits. thanks
BTW, any reason to set this limit, do you meet any limitation on lvm/linux? |
Signed-off-by: dongjiang1989 <[email protected]>
Setting a reasonable number of volumes is related to Node disk pressure and Pod balanced deployment. @peter-wangxu Please re-check |
MaxVolumesPerNode
setting
@peter-wangxu Please release patch version 🤔️ |
I have not verify this version in production env, do you mind a pre-relase for current version? |
Yes. Pre-release versions are helpful to me |
This PR adds support for returning max volume limit in CSI NodeGetInfo call, It returns MaxVolumesPerNode in CSINodeGetInfo response, which defaults to 64, This can be configured via
MAX_VOLUMES_PERNODE
from ENV config.