-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added README for esbuild package #1416
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few minor things
@@ -0,0 +1,140 @@ | |||
# ESbuild | |||
Esbuild is a module bundler and minifier for JavaScript and CSS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this might work with CSS, we don't use that here. We just use it to bundle JS and TS 🙂
}, | ||
}); | ||
``` | ||
where `process.env.EXAMPLE_VAR` is replace with `exampleValue` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace
-> replaced
Default: **info** | ||
|
||
### `sourcemap` (boolean, default) | ||
Source maps encode the information necessary to translate from a line/column offset in a generate output file back to a line/column offset in the corresponding original input file. Supported for both Javascript and CSS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again I'd just remove the reference to CSS
Description of the proposed changes
Added initial README for esbuild, backwards engineering the definitions from the code. README includes:
Screenshots (if applicable)
Other solutions considered (if any)
Notes to PR author
Notes to reviewers