Chore/lambda event source mapping #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crispy101
requested review from
AdamJHall,
gowrizrh and
TheOrangePuff
and removed request for
a team,
AdamJHall and
gowrizrh
TheOrangePuff
requested changes
Dec 8, 2024
| resources: [ | ||
| `arn:aws:lambda:${region}:${accountId}:event-source-mapping:*`, | ||
| ], | ||
| actions: ["lambda:TagResource"], |
TheOrangePuff
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change alternatvie to #53
This is to allow the role to tag "event-source-mapping" resources, which can't be identified by any qualifiers, e.g.
arn:aws:lambda:ap-southeast-2:123456789012:event-source-mapping:1bfc3b83-2c0a-49d8-b7b6-ed1dfcc099b6While on it, we might as well merge the ones below to this new item, as they all are about EventSourceMapping. Thoughts, @TheOrangePuff ?