Empowerment & A little bit Optimization #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimizations: - Using OnClientSayCommand instead of say & say_team hooks. - A little bit reduced memory usage. - Using FormatEx instead of Format, where using Format it is not necessary. Empowerment's: - Repaced Health overflow spawn protection on godmode method. That's better, becouse if some plugins change HP in interval between start of spawn protection and end of spawn protection, in result - HP reverts back. - Added ConVar "cssdm_addictional_menu_cmds". When player presses F1 / F2 buttons - he do not need to type "guns" into chat.
|
@Drifter321, no answer to my pull request? |
|
Everything looks good to me however, there currently exists a problem with the building of CSSDM using a very old version of SM for the plugins that needs to be fixed before it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizations:
Empowerment's:
-Replaced Health overflow spawn protection on godmode method.
That's
better, because if some plugins change HP in interval between
start of
spawn protection and end of spawn protection, in result - HP reverts
back.
When player
presses F1 / F2 buttons - he do not need to type "guns" into chat.