Fix validation of rtti debug sections in VM #1018
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .dbg.locals table contains individual entries for the arguments of a function. When parsing that section, individual entries can be of arguments passed by reference.
The "address" of a constant is the constant's value itself after 0471d9e.
dvander
reviewed
Jan 6, 2025
tests/runtests.py
Outdated
| @@ -131,14 +131,14 @@ def find_shells(self): | |||
| if rc == 0 and 'JIT' in stdout: | |||
| self.shells.append({ | |||
| 'path': path, | |||
| 'args': [], | |||
| 'args': ['--validate-debug-sections'], | |||
There was a problem hiding this comment.
Any reason not to make this the default for the shell?
There was a problem hiding this comment.
Nope, sounds good too.
Check if we're still emitting the expected debug information format.
peace-maker
force-pushed
the
validate_debug_syms
branch
from
cf0fd66 to
5ed9b39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabling the line debugger feature, the
.dbg.*sections emitted by the current compiler don't pass the method-verifier in the VM anymore. Fix the problems and enable validation in tests too, to prevent this from diverging again.This path can be triggered when enabling the line debugger in sourcemod. alliedmodders/sourcemod#2240