Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(consensus): blanket impl of Transaction for deref #1412

Closed
wants to merge 2 commits into from
Closed

chore(consensus): blanket impl of Transaction for deref #1412

wants to merge 2 commits into from

Conversation

emhane
Copy link
Contributor

@emhane emhane commented Oct 2, 2024

Motivation

Simplifies plugging in a new type that derefs to an existing type that impl trait Transaction

Solution

Add blanket impl of Transaction for all types that deref to a type that impl Transaction

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@emhane emhane added the debt Tech debt which needs to be addressed label Oct 2, 2024
@emhane emhane marked this pull request as draft October 2, 2024 10:08
mattsse
mattsse reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, this could be problematic because then you can't have both deref for the wrapper inner tx and a modified transaction trait impl

imo we should leave this up to the user

@emhane emhane closed this Oct 3, 2024
@emhane emhane reopened this Oct 3, 2024
@emhane emhane closed this Oct 3, 2024
@emhane emhane deleted the emhane/transaction branch October 3, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse left review comments

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

@klkvr klkvr Awaiting requested review from klkvr klkvr will be requested when the pull request is marked ready for review klkvr is a code owner

Assignees
No one assigned
Labels
debt Tech debt which needs to be addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse