Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(consensus): add Transaction::size into trait Transaction #1415

Closed
wants to merge 1 commit into from
Closed

chore(consensus): add Transaction::size into trait Transaction #1415

wants to merge 1 commit into from

Conversation

emhane
Copy link
Contributor

@emhane emhane commented Oct 2, 2024

Motivation

Transaction::size must be accessible via abstraction Transaction in reth sdk

Follows pattern of header primitive #1414

Solution

Add Transaction::size into trait method of Transaction

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@emhane emhane added the debt Tech debt which needs to be addressed label Oct 2, 2024
@emhane emhane marked this pull request as draft October 2, 2024 10:08
@emhane emhane closed this Oct 3, 2024
@emhane emhane deleted the emhane/tx-size branch October 3, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

@klkvr klkvr Awaiting requested review from klkvr klkvr will be requested when the pull request is marked ready for review klkvr is a code owner

Assignees
No one assigned
Labels
debt Tech debt which needs to be addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emhane